Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 78c696c1 authored by Sebastian Andrzej Siewior's avatar Sebastian Andrzej Siewior Committed by David S. Miller
Browse files

isdn: gigaset: use usb_fill_int_urb() 



Using usb_fill_int_urb() helps to find code which initializes an
URB. A grep for members of the struct (like ->complete) reveal lots
of other things, too.

Cc: Paul Bolle <pebolle@tiscali.nl>
Cc: Karsten Keil <isdn@linux-pingi.de>
Cc: gigaset307x-common@lists.sourceforge.net
Cc: netdev@vger.kernel.org
Signed-off-by: default avatarSebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e8f5b035

drivers/isdn/gigaset/bas-gigaset.c

+12 −14
Original line number Diff line number Diff line
@@ -972,16 +972,14 @@ static int starturbs(struct bc_state *bcs) 
			rc = -EFAULT;

			goto error;

		}

		usb_fill_int_urb(urb, bcs->cs->hw.bas->udev,

				 usb_rcvisocpipe(urb->dev, 3 + 2 * bcs->channel),

				 ubc->isoinbuf + k * BAS_INBUFSIZE,

				 BAS_INBUFSIZE, read_iso_callback, bcs,

				 BAS_FRAMETIME);



		urb->dev = bcs->cs->hw.bas->udev;

		urb->pipe = usb_rcvisocpipe(urb->dev, 3 + 2 * bcs->channel);

		urb->transfer_flags = URB_ISO_ASAP;

		urb->transfer_buffer = ubc->isoinbuf + k * BAS_INBUFSIZE;

		urb->transfer_buffer_length = BAS_INBUFSIZE;

		urb->number_of_packets = BAS_NUMFRAMES;

		urb->interval = BAS_FRAMETIME;

		urb->complete = read_iso_callback;

		urb->context = bcs;

		for (j = 0; j < BAS_NUMFRAMES; j++) {

			urb->iso_frame_desc[j].offset = j * BAS_MAXFRAME;

			urb->iso_frame_desc[j].length = BAS_MAXFRAME;
@@ -1005,15 +1003,15 @@ static int starturbs(struct bc_state *bcs) 
			rc = -EFAULT;

			goto error;

		}

		urb->dev = bcs->cs->hw.bas->udev;

		urb->pipe = usb_sndisocpipe(urb->dev, 4 + 2 * bcs->channel);

		usb_fill_int_urb(urb, bcs->cs->hw.bas->udev,

				 usb_sndisocpipe(urb->dev, 4 + 2 * bcs->channel),

				 ubc->isooutbuf->data,

				 sizeof(ubc->isooutbuf->data),

				 write_iso_callback, &ubc->isoouturbs[k],

				 BAS_FRAMETIME);



		urb->transfer_flags = URB_ISO_ASAP;

		urb->transfer_buffer = ubc->isooutbuf->data;

		urb->transfer_buffer_length = sizeof(ubc->isooutbuf->data);

		urb->number_of_packets = BAS_NUMFRAMES;

		urb->interval = BAS_FRAMETIME;

		urb->complete = write_iso_callback;

		urb->context = &ubc->isoouturbs[k];

		for (j = 0; j < BAS_NUMFRAMES; ++j) {

			urb->iso_frame_desc[j].offset = BAS_OUTBUFSIZE;

			urb->iso_frame_desc[j].length = BAS_NORMFRAME;