Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 788faab7 authored by Tobias Tefke's avatar Tobias Tefke Committed by Ingo Molnar
Browse files

perf, tools: Use correct articles in comments 



Some of the comments in the perf events code use articles incorrectly,
using 'a' for words beginning with a vowel sound, where 'an' should be
used.

Signed-off-by: default avatarTobias Tefke <tobias.tefke@tutanota.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: acme@kernel.org
Cc: alexander.shishkin@linux.intel.com
Cc: jolsa@redhat.com
Cc: namhyung@kernel.org
Link: http://lkml.kernel.org/r/20180709105715.22938-1-tobias.tefke@tutanota.com


[ Fix a few more perf related 'a event' typo fixes from all around the kernel and tooling tree. ]
Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent 26c6ccdf

arch/powerpc/perf/core-book3s.c

+3 −3
Original line number Diff line number Diff line
@@ -1469,7 +1469,7 @@ static int collect_events(struct perf_event *group, int max_count, 
}



/*

 * Add a event to the PMU.

 * Add an event to the PMU.

 * If all events are not already frozen, then we disable and

 * re-enable the PMU in order to get hw_perf_enable to do the

 * actual work of reconfiguring the PMU.
@@ -1548,7 +1548,7 @@ static int power_pmu_add(struct perf_event *event, int ef_flags) 
}



/*

 * Remove a event from the PMU.

 * Remove an event from the PMU.

 */

static void power_pmu_del(struct perf_event *event, int ef_flags)

{
@@ -1742,7 +1742,7 @@ static int power_pmu_commit_txn(struct pmu *pmu) 
/*

 * Return 1 if we might be able to put event on a limited PMC,

 * or 0 if not.

 * A event can only go on a limited PMC if it counts something

 * An event can only go on a limited PMC if it counts something

 * that a limited PMC can count, doesn't require interrupts, and

 * doesn't exclude any processor mode.

 */

include/linux/perf_event.h

+1 −1
Original line number Diff line number Diff line
@@ -490,7 +490,7 @@ struct perf_addr_filters_head { 
};



/**

 * enum perf_event_state - the states of a event

 * enum perf_event_state - the states of an event:

 */

enum perf_event_state {

	PERF_EVENT_STATE_DEAD		= -4,

kernel/events/core.c

+8 −8
Original line number Diff line number Diff line
@@ -1656,7 +1656,7 @@ perf_event_groups_next(struct perf_event *event) 
				typeof(*event), group_node))



/*

 * Add a event from the lists for its context.

 * Add an event from the lists for its context.

 * Must be called with ctx->mutex and ctx->lock held.

 */

static void
@@ -1844,7 +1844,7 @@ static void perf_group_attach(struct perf_event *event) 
}



/*

 * Remove a event from the lists for its context.

 * Remove an event from the lists for its context.

 * Must be called with ctx->mutex and ctx->lock held.

 */

static void
@@ -2148,7 +2148,7 @@ static void __perf_event_disable(struct perf_event *event, 
}



/*

 * Disable a event.

 * Disable an event.

 *

 * If event->ctx is a cloned context, callers must make sure that

 * every task struct that event->ctx->task could possibly point to
@@ -2677,7 +2677,7 @@ static void __perf_event_enable(struct perf_event *event, 
}



/*

 * Enable a event.

 * Enable an event.

 *

 * If event->ctx is a cloned context, callers must make sure that

 * every task struct that event->ctx->task could possibly point to
@@ -2755,7 +2755,7 @@ static int __perf_event_stop(void *info) 
	 * events will refuse to restart because of rb::aux_mmap_count==0,

	 * see comments in perf_aux_output_begin().

	 *

	 * Since this is happening on a event-local CPU, no trace is lost

	 * Since this is happening on an event-local CPU, no trace is lost

	 * while restarting.

	 */

	if (sd->restart)
@@ -4827,7 +4827,7 @@ __perf_read(struct perf_event *event, char __user *buf, size_t count) 
	int ret;



	/*

	 * Return end-of-file for a read on a event that is in

	 * Return end-of-file for a read on an event that is in

	 * error state (i.e. because it was pinned but it couldn't be

	 * scheduled on to the CPU at some point).

	 */
@@ -9898,7 +9898,7 @@ static void account_event(struct perf_event *event) 
}



/*

 * Allocate and initialize a event structure

 * Allocate and initialize an event structure

 */

static struct perf_event *

perf_event_alloc(struct perf_event_attr *attr, int cpu,
@@ -11229,7 +11229,7 @@ const struct perf_event_attr *perf_event_attrs(struct perf_event *event) 
}



/*

 * Inherit a event from parent task to child task.

 * Inherit an event from parent task to child task.

 *

 * Returns:

 *  - valid pointer on success

kernel/events/uprobes.c

+3 −3
Original line number Diff line number Diff line
@@ -918,7 +918,7 @@ int uprobe_register(struct inode *inode, loff_t offset, struct uprobe_consumer * 
EXPORT_SYMBOL_GPL(uprobe_register);



/*

 * uprobe_apply - unregister a already registered probe.

 * uprobe_apply - unregister an already registered probe.

 * @inode: the file in which the probe has to be removed.

 * @offset: offset from the start of the file.

 * @uc: consumer which wants to add more or remove some breakpoints
@@ -947,7 +947,7 @@ int uprobe_apply(struct inode *inode, loff_t offset, 
}



/*

 * uprobe_unregister - unregister a already registered probe.

 * uprobe_unregister - unregister an already registered probe.

 * @inode: the file in which the probe has to be removed.

 * @offset: offset from the start of the file.

 * @uc: identify which probe if multiple probes are colocated.
@@ -1403,7 +1403,7 @@ static struct return_instance *free_ret_instance(struct return_instance *ri) 


/*

 * Called with no locks held.

 * Called in context of a exiting or a exec-ing thread.

 * Called in context of an exiting or an exec-ing thread.

 */

void uprobe_free_utask(struct task_struct *t)

{

tools/perf/Documentation/perf-list.txt

+1 −1
Original line number Diff line number Diff line
@@ -234,7 +234,7 @@ perf also supports group leader sampling using the :S specifier. 
  perf record -e '{cycles,instructions}:S' ...

  perf report --group



Normally all events in a event group sample, but with :S only

Normally all events in an event group sample, but with :S only

the first event (the leader) samples, and it only reads the values of the

other events in the group.