Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7853b49c authored by Netanel Belgazal's avatar Netanel Belgazal Committed by David S. Miller
Browse files

net: ena: unmask MSI-X only after device initialization is completed 



Under certain conditions MSI-X interrupt might arrive right after it
was unmasked in ena_up(). There is a chance it would be processed by
the driver before device ENA_FLAG_DEV_UP flag is set. In such a case
the interrupt is ignored.
ENA device operates in auto-masked mode, therefore ignoring
interrupt leaves it masked for good.
Moving unmask of interrupt to be the last step in ena_up().

Signed-off-by: default avatarNetanel Belgazal <netanel@amazon.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 15962a18

drivers/net/ethernet/amazon/ena/ena_netdev.c

+13 −13
Original line number Diff line number Diff line
@@ -1565,7 +1565,7 @@ static int ena_rss_configure(struct ena_adapter *adapter) 


static int ena_up_complete(struct ena_adapter *adapter)

{

	int rc, i;

	int rc;



	rc = ena_rss_configure(adapter);

	if (rc)
@@ -1584,17 +1584,6 @@ static int ena_up_complete(struct ena_adapter *adapter) 


	ena_napi_enable_all(adapter);



	/* Enable completion queues interrupt */

	for (i = 0; i < adapter->num_queues; i++)

		ena_unmask_interrupt(&adapter->tx_ring[i],

				     &adapter->rx_ring[i]);



	/* schedule napi in case we had pending packets

	 * from the last time we disable napi

	 */

	for (i = 0; i < adapter->num_queues; i++)

		napi_schedule(&adapter->ena_napi[i].napi);



	return 0;

}
@@ -1731,7 +1720,7 @@ static int ena_create_all_io_rx_queues(struct ena_adapter *adapter) 


static int ena_up(struct ena_adapter *adapter)

{

	int rc;

	int rc, i;



	netdev_dbg(adapter->netdev, "%s\n", __func__);
@@ -1774,6 +1763,17 @@ static int ena_up(struct ena_adapter *adapter) 


	set_bit(ENA_FLAG_DEV_UP, &adapter->flags);



	/* Enable completion queues interrupt */

	for (i = 0; i < adapter->num_queues; i++)

		ena_unmask_interrupt(&adapter->tx_ring[i],

				     &adapter->rx_ring[i]);



	/* schedule napi in case we had pending packets

	 * from the last time we disable napi

	 */

	for (i = 0; i < adapter->num_queues; i++)

		napi_schedule(&adapter->ena_napi[i].napi);



	return rc;



err_up: