Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 776b6453 authored by Phil Turnbull's avatar Phil Turnbull Committed by Jonathan Cameron
Browse files

staging: iio: ad5933: Return correct value for AD5933_OUT_RANGE. 



The 'break' statement after calling ad5933_cmd only breaks out of the
'for' loop, which then unconditionally sets the return value to -EINVAL.
Move the initialisation of 'ret' so we return the correct value.

Signed-off-by: default avatarPhil Turnbull <phil.turnbull@oracle.com>
Signed-off-by: default avatarJonathan Cameron <jic23@kernel.org>
parent bb9947c3

drivers/staging/iio/impedance-analyzer/ad5933.c

+1 −1
Original line number Diff line number Diff line
@@ -419,6 +419,7 @@ static ssize_t ad5933_store(struct device *dev, 
	mutex_lock(&indio_dev->mlock);

	switch ((u32)this_attr->address) {

	case AD5933_OUT_RANGE:

		ret = -EINVAL;

		for (i = 0; i < 4; i++)

			if (val == st->range_avail[i]) {

				st->ctrl_hb &= ~AD5933_CTRL_RANGE(0x3);
@@ -426,7 +427,6 @@ static ssize_t ad5933_store(struct device *dev, 
				ret = ad5933_cmd(st, 0);

				break;

			}

		ret = -EINVAL;

		break;

	case AD5933_IN_PGA_GAIN:

		if (sysfs_streq(buf, "1")) {