Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 773aaadc authored by Colin Ian King's avatar Colin Ian King Committed by Boris Ostrovsky
Browse files

xen/pvcalls: remove redundant check for irq >= 0 



This is a moot point, but irq is always less than zero at the label
out_error, so the check for irq >= 0 is redundant and can be removed.

Detected by CoverityScan, CID#1460371 ("Logically dead code")

Fixes: cb1c7d9b ("xen/pvcalls: implement connect command")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Reviewed-by: default avatarJuergen Gross <jgross@suse.com>
Signed-off-by: default avatarBoris Ostrovsky <boris.ostrovsky@oracle.com>
parent 95110ac8

drivers/xen/pvcalls-front.c

+1 −3
Original line number Diff line number Diff line
@@ -351,9 +351,7 @@ static int create_active(struct sock_mapping *map, int *evtchn) 
	return 0;



out_error:

	if (irq >= 0)

		unbind_from_irqhandler(irq, map);

	else if (*evtchn >= 0)

	if (*evtchn >= 0)

		xenbus_free_evtchn(pvcalls_front_dev, *evtchn);

	kfree(map->active.data.in);

	kfree(map->active.ring);