Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 76cefef8 authored by Arnd Bergmann's avatar Arnd Bergmann
Browse files

firmware: ti_sci: fix strncat length check 



gcc-7 notices that the length we pass to strncat is wrong:

drivers/firmware/ti_sci.c: In function 'ti_sci_probe':
drivers/firmware/ti_sci.c:204:32: error: specified bound 50 equals the size of the destination [-Werror=stringop-overflow=]

Instead of the total length, we must pass the length of the
remaining space here.

Fixes: aa276781 ("firmware: Add basic support for TI System Control Interface (TI-SCI) protocol")
Cc: stable@vger.kernel.org
Acked-by: default avatarNishanth Menon <nm@ti.com>
Acked-by: default avatarSantosh Shilimkar <ssantosh@kernel.org>
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
parent 0527873b

drivers/firmware/ti_sci.c

+2 −1
Original line number Diff line number Diff line
@@ -202,7 +202,8 @@ static int ti_sci_debugfs_create(struct platform_device *pdev, 
	info->debug_buffer[info->debug_region_size] = 0;



	info->d = debugfs_create_file(strncat(debug_name, dev_name(dev),

					      sizeof(debug_name)),

					      sizeof(debug_name) -

					      sizeof("ti_sci_debug@")),

				      0444, NULL, info, &ti_sci_debug_fops);

	if (IS_ERR(info->d))

		return PTR_ERR(info->d);