Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 76548eda authored by Alan Cox's avatar Alan Cox Committed by Jeff Garzik
Browse files

libata-sff: tf_load 



Jeff said he preferred that the SFF tf_load followed the spec and we
documented that anyone who needed different overrode it, rather than it
using the ->check_status methods. No driver relies on the current behaviour.

Signed-off-by: default avatarAlan Cox <alan@redhat.com>
Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
parent b9f8ab2d

drivers/ata/libata-sff.c

+4 −2
Original line number Original line Diff line number Diff line
@@ -147,7 +147,9 @@ void ata_exec_command(struct ata_port *ap, const struct ata_taskfile *tf) 
 *	@tf: ATA taskfile register set for storing input

 *	@tf: ATA taskfile register set for storing input

 *

 *

 *	Reads ATA taskfile registers for currently-selected device

 *	Reads ATA taskfile registers for currently-selected device

 *	into @tf.

 *	into @tf. Assumes the device has a fully SFF compliant task file

 *	layout and behaviour. If you device does not (eg has a different

 *	status method) then you will need to provide a replacement tf_read

 *

 *

 *	LOCKING:

 *	LOCKING:

 *	Inherited from caller.

 *	Inherited from caller.
@@ -156,7 +158,7 @@ void ata_tf_read(struct ata_port *ap, struct ata_taskfile *tf) 
{

{

	struct ata_ioports *ioaddr = &ap->ioaddr;

	struct ata_ioports *ioaddr = &ap->ioaddr;





	tf->command = ata_chk_status(ap);

	tf->command = ata_check_status(ap);

	tf->feature = ioread8(ioaddr->error_addr);

	tf->feature = ioread8(ioaddr->error_addr);

	tf->nsect = ioread8(ioaddr->nsect_addr);

	tf->nsect = ioread8(ioaddr->nsect_addr);

	tf->lbal = ioread8(ioaddr->lbal_addr);

	tf->lbal = ioread8(ioaddr->lbal_addr);