Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 75da9606 authored by Denis Drozdov's avatar Denis Drozdov Committed by Jason Gunthorpe
Browse files

IB/IPoIB: Set ah valid flag in multicast send flow 



The change of ipoib_ah data structure with adding "valid" flag and
checks of ah->valid in ipoib_start_xmit affected multicast packet flow.

Since the multicast flow doesn't invoke path_rec_start, "ah->valid" flag
remains unset, so that ipoib_start_xmit end up with neigh_refresh_path
instead of sending the packet using neigh.

"ah->valid" has to be set in multicast send flow. As a result IPoIB
starts sending packets via neigh immediately and eliminates 60sec delay
of neigh keep alive interval.

The typical example of this issue are two sequential arpings:

arping 11.134.208.9 -> got response (mcast_send)
arping 11.134.208.9 -> no response  (ah->valid = 0)

Fixes: fa9391db ("RDMA/ipoib: Update paths on CLIENT_REREG/SM_CHANGE events")
Signed-off-by: default avatarDenis Drozdov <denisd@mellanox.com>
Reviewed-by: default avatarErez Shitrit <erezsh@mellanox.com>
Reviewed-by: default avatarFeras Daoud <ferasda@mellanox.com>
Signed-off-by: default avatarLeon Romanovsky <leonro@mellanox.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
parent 0f50d88a

drivers/infiniband/ulp/ipoib/ipoib_multicast.c

+1 −0
Original line number Diff line number Diff line
@@ -822,6 +822,7 @@ void ipoib_mcast_send(struct net_device *dev, u8 *daddr, struct sk_buff *skb) 
			if (neigh && list_empty(&neigh->list)) {

				kref_get(&mcast->ah->ref);

				neigh->ah	= mcast->ah;

				neigh->ah->valid = 1;

				list_add_tail(&neigh->list, &mcast->neigh_list);

			}

		}