Commit 74a2b96e authored Jan 30, 2017 by Arvind Yadav Committed by Bartlomiej Zolnierkiewicz Jan 30, 2017

video: fbdev: stifb: handle NULL return value from ioremap_nocache

Add missing error check for ioremap_nocache() failure
(prevents NULL pointer dereference on error).

Cc: "James E.J. Bottomley" <jejb@parisc-linux.org>
Cc: Helge Deller <deller@gmx.de>
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
[b.zolnierkie: minor fixes]
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

parent f998ff68

drivers/video/fbdev/stifb.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -1294,6 +1294,10 @@ static int __init stifb_init_fb(struct sti_struct *sti, int bpp_pref)
		strcpy(fix->id, "stifb");
		info->fbops = &stifb_ops;
		info->screen_base = ioremap_nocache(REGION_BASE(fb,1), fix->smem_len);
		if (!info->screen_base) {
		printk(KERN_ERR "stifb: failed to map memory\n");
		goto out_err0;
		}
		info->screen_size = fix->smem_len;
		info->flags = FBINFO_DEFAULT \| FBINFO_HWACCEL_COPYAREA;
		info->pseudo_palette = &fb->pseudo_palette;