Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 747598d5 authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab
Browse files

[media] go7007: don't use vb before test if it is not NULL 



As reported by smatch:
	drivers/media/usb/go7007/go7007-driver.c:452 frame_boundary() warn: variable dereferenced before check 'vb' (see line 449)

Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
Acked-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent efc0ac5a

drivers/media/usb/go7007/go7007-driver.c

+2 −1
Original line number Diff line number Diff line
@@ -446,7 +446,7 @@ static void go7007_motion_regions(struct go7007 *go, struct go7007_buffer *vb) 
 */

static struct go7007_buffer *frame_boundary(struct go7007 *go, struct go7007_buffer *vb)

{

	u32 *bytesused = &vb->vb.v4l2_planes[0].bytesused;

	u32 *bytesused;

	struct go7007_buffer *vb_tmp = NULL;



	if (vb == NULL) {
@@ -458,6 +458,7 @@ static struct go7007_buffer *frame_boundary(struct go7007 *go, struct go7007_buf 
		go->next_seq++;

		return vb;

	}

	bytesused = &vb->vb.v4l2_planes[0].bytesused;



	vb->vb.v4l2_buf.sequence = go->next_seq++;

	if (vb->modet_active && *bytesused + 216 < GO7007_BUF_SIZE)