Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 74391e12 authored by navin patidar's avatar navin patidar Committed by Greg Kroah-Hartman
Browse files

staging: rtl8188eu: Remove _ReadLEDSetting() function. 



_ReadLEDSetting() doesn't read led settings this function actually
initialize  member variables of struct led_priv, we should do that
inside rtl8188eu_InitSwLeds().

Signed-off-by: default avatarnavin patidar <navin.patidar@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 105dec7d

drivers/staging/rtl8188eu/hal/rtl8188eu_led.c

+4 −0
Original line number Diff line number Diff line
@@ -92,8 +92,12 @@ void SwLedOff(struct adapter *padapter, struct LED_871x *pLed) 
void rtl8188eu_InitSwLeds(struct adapter *padapter)

{

	struct led_priv *pledpriv = &(padapter->ledpriv);

	struct hal_data_8188e   *haldata = GET_HAL_DATA(padapter);



	pledpriv->bRegUseLed = true;

	pledpriv->LedStrategy = SW_LED_MODE1;

	pledpriv->LedControlHandler = LedControl8188eu;

	haldata->bLedOpenDrain = true;



	InitLed871x(padapter, &(pledpriv->SwLed0), LED_PIN_LED0);

drivers/staging/rtl8188eu/hal/usb_halinit.c

+0 −12
Original line number Diff line number Diff line
@@ -1129,16 +1129,6 @@ static unsigned int rtl8188eu_inirp_deinit(struct adapter *Adapter) 
/*	EEPROM/EFUSE Content Parsing */

/*  */

/*  */

static void _ReadLEDSetting(struct adapter *Adapter, u8 *PROMContent, bool AutoloadFail)

{

	struct led_priv *pledpriv = &(Adapter->ledpriv);

	struct hal_data_8188e	*haldata = GET_HAL_DATA(Adapter);



	pledpriv->bRegUseLed = true;

	pledpriv->LedStrategy = SW_LED_MODE1;

	haldata->bLedOpenDrain = true;/*  Support Open-drain arrangement for controlling the LED. */

}



static void Hal_EfuseParsePIDVID_8188EU(struct adapter *adapt, u8 *hwinfo, bool AutoLoadFail)

{

	struct hal_data_8188e	*haldata = GET_HAL_DATA(adapt);
@@ -1215,8 +1205,6 @@ readAdapterInfo_8188EU( 
	/*  */

	Hal_InitChannelPlan(adapt);

	Hal_CustomizeByCustomerID_8188EU(adapt);



	_ReadLEDSetting(adapt, eeprom->efuse_eeprom_data, eeprom->bautoload_fail_flag);

}



static void _ReadPROMContent(