Commit 741de617 authored Mar 27, 2018 by Nicholas Piggin Committed by Michael Ellerman Mar 31, 2018

powerpc/powernv: Handle unknown OPAL errors in opal_nvram_write()



opal_nvram_write currently just assumes success if it encounters an
error other than OPAL_BUSY or OPAL_BUSY_EVENT. Have it return -EIO
on other errors instead.

Fixes: 628daa8d ("powerpc/powernv: Add RTC and NVRAM support plus RTAS fallbacks")
Cc: stable@vger.kernel.org # v3.2+
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
Reviewed-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
Acked-by: Stewart Smith <stewart@linux.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

parent 0f9bdfe3

arch/powerpc/platforms/powernv/opal-nvram.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -59,6 +59,10 @@ static ssize_t opal_nvram_write(char buf, size_t count, loff_t index)
		if (rc == OPAL_BUSY_EVENT)
		opal_poll_events(NULL);
		}

		if (rc)
		return -EIO;

		*index += count;
		return count;
		}