Commit 73fab6ff authored Dec 11, 2017 by Stefan Raspl Committed by Paolo Bonzini Dec 14, 2017

tools/kvm_stat: stop ignoring unhandled arguments



Unhandled arguments, which could easily include typos, are simply
ignored. We should be strict to avoid undetected typos.
To reproduce start kvm_stat with an extra argument, e.g.
'kvm_stat -d bnuh5ol' and note that this will actually work.

Signed-off-by: Stefan Raspl <raspl@linux.vnet.ibm.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

parent 822cfe3e

tools/kvm/kvm_stat/kvm_stat

+3 −1

Original line number	Diff line number	Diff line
		@@ -1517,7 +1517,9 @@ Press any other key to refresh statistics immediately.
		help='restrict statistics to guest by name',
		callback=cb_guest_to_pid,
		)
		(options, _) = optparser.parse_args(sys.argv)
		options, unkn = optparser.parse_args(sys.argv)
		if len(unkn) != 1:
		sys.exit('Error: Extra argument(s): ' + ' '.join(unkn[1:]))
		try:
		# verify that we were passed a valid regex up front
		re.compile(options.fields)