Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 735f61e6 authored by Andy Grover's avatar Andy Grover Committed by David S. Miller
Browse files

RDS: Do not BUG() on error returned from ib_post_send 



BUGging on a runtime error code should be avoided. This
patch also eliminates all other BUG()s that have no real
reason to exist.

Signed-off-by: default avatarAndy Grover <andy.grover@oracle.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 87faf3cc

net/rds/ib_recv.c

+2 −2
Original line number Diff line number Diff line
@@ -468,8 +468,8 @@ static void rds_ib_send_ack(struct rds_ib_connection *ic, unsigned int adv_credi 
		set_bit(IB_ACK_REQUESTED, &ic->i_ack_flags);



		rds_ib_stats_inc(s_ib_ack_send_failure);

		/* Need to finesse this later. */

		BUG();



		rds_ib_conn_error(ic->conn, "sending ack failed\n");

	} else

		rds_ib_stats_inc(s_ib_ack_sent);

}

net/rds/ib_send.c

+3 −4
Original line number Diff line number Diff line
@@ -574,8 +574,7 @@ int rds_ib_xmit(struct rds_connection *conn, struct rds_message *rm, 
		rds_ib_send_grab_credits(ic, 0, &posted, 1, RDS_MAX_ADV_CREDIT - adv_credits);

		adv_credits += posted;

		BUG_ON(adv_credits > 255);

	} else if (ic->i_rm != rm)

		BUG();

	}



	send = &ic->i_sends[pos];

	first = send;
@@ -714,8 +713,8 @@ int rds_ib_xmit(struct rds_connection *conn, struct rds_message *rm, 
			ic->i_rm = prev->s_rm;

			prev->s_rm = NULL;

		}

		/* Finesse this later */

		BUG();



		rds_ib_conn_error(ic->conn, "ib_post_send failed\n");

		goto out;

	}

net/rds/iw_recv.c

+2 −2
Original line number Diff line number Diff line
@@ -468,8 +468,8 @@ static void rds_iw_send_ack(struct rds_iw_connection *ic, unsigned int adv_credi 
		set_bit(IB_ACK_REQUESTED, &ic->i_ack_flags);



		rds_iw_stats_inc(s_iw_ack_send_failure);

		/* Need to finesse this later. */

		BUG();



		rds_iw_conn_error(ic->conn, "sending ack failed\n");

	} else

		rds_iw_stats_inc(s_iw_ack_sent);

}

net/rds/iw_send.c

+1 −2
Original line number Diff line number Diff line
@@ -616,8 +616,7 @@ int rds_iw_xmit(struct rds_connection *conn, struct rds_message *rm, 
		rds_iw_send_grab_credits(ic, 0, &posted, 1, RDS_MAX_ADV_CREDIT - adv_credits);

		adv_credits += posted;

		BUG_ON(adv_credits > 255);

	} else if (ic->i_rm != rm)

		BUG();

	}



	send = &ic->i_sends[pos];

	first = send;

net/rds/rdma_transport.c

+1 −2
Original line number Diff line number Diff line
@@ -109,8 +109,7 @@ int rds_rdma_cm_event_handler(struct rdma_cm_id *cm_id, 


	default:

		/* things like device disconnect? */

		printk(KERN_ERR "unknown event %u\n", event->event);

		BUG();

		printk(KERN_ERR "RDS: unknown event %u!\n", event->event);

		break;

	}