Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 734f3863 authored by oulijun's avatar oulijun Committed by Doug Ledford
Browse files

RDMA/hns: Remove some unnecessary attr_mask judgement 



This patch deletes some unnecessary attr_mask if condition
in hip08 according to the IB protocol.

Signed-off-by: default avatarLijun Ou <oulijun@huawei.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 6852af86

drivers/infiniband/hw/hns/hns_roce_hw_v2.c

+4 −7
Original line number Diff line number Diff line
@@ -2655,8 +2655,7 @@ static int modify_qp_init_to_rtr(struct ib_qp *ibqp, 
		return -EINVAL;

	}



	if ((attr_mask & IB_QP_ALT_PATH) || (attr_mask & IB_QP_ACCESS_FLAGS) ||

	    (attr_mask & IB_QP_PKEY_INDEX) || (attr_mask & IB_QP_QKEY)) {

	if (attr_mask & IB_QP_ALT_PATH) {

		dev_err(dev, "INIT2RTR attr_mask (0x%x) error\n", attr_mask);

		return -EINVAL;

	}
@@ -2927,11 +2926,9 @@ static int modify_qp_rtr_to_rts(struct ib_qp *ibqp, 
		return -EINVAL;

	}



	/* If exist optional param, return error */

	if ((attr_mask & IB_QP_ALT_PATH) || (attr_mask & IB_QP_ACCESS_FLAGS) ||

	    (attr_mask & IB_QP_QKEY) || (attr_mask & IB_QP_PATH_MIG_STATE) ||

	    (attr_mask & IB_QP_CUR_STATE) ||

	    (attr_mask & IB_QP_MIN_RNR_TIMER)) {

	/* Not support alternate path and path migration */

	if ((attr_mask & IB_QP_ALT_PATH) ||

	    (attr_mask & IB_QP_PATH_MIG_STATE)) {

		dev_err(dev, "RTR2RTS attr_mask (0x%x)error\n", attr_mask);

		return -EINVAL;

	}