Commit 72409705 authored Oct 15, 2015 by Dan Carpenter Committed by Takashi Iwai Oct 17, 2015

ALSA: firewire-tascam: off by one in handle_midi_tx()

My static checker complains because tscm->spec->midi_capture_ports is
either 2 or 4 but the tscm->tx_midi_substreams[] array has 4 elements so
this is possibly off by one. I have looked at the code and I think it
should be >= instead of > as well.

Fixes: 107cc012 ('ALSA: firewire-tascam: add support for incoming MIDI messages by asynchronous transaction')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent 69ec98d7

sound/firewire/tascam/tascam-transaction.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -158,7 +158,7 @@ static void handle_midi_tx(struct fw_card card, struct fw_request request,

		port = b[0] >> 4;
		/* TODO: support virtual MIDI ports. */
		if (port > tscm->spec->midi_capture_ports)
		if (port >= tscm->spec->midi_capture_ports)
		goto end;

		/* Assume the message length. */