Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 71cd2aa5 authored by Alexander Aring's avatar Alexander Aring Committed by Marcel Holtmann
Browse files

mac802154: llsec: use kzfree



This patch will use kzfree instead kfree for security related
information which can be offered by acccident.

Signed-off-by: default avatarAlexander Aring <alex.aring@gmail.com>
Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
parent a6ad2a6b
Loading
Loading
Loading
Loading
+10 −10
Original line number Diff line number Diff line
@@ -55,7 +55,7 @@ void mac802154_llsec_destroy(struct mac802154_llsec *sec)

		msl = container_of(sl, struct mac802154_llsec_seclevel, level);
		list_del(&sl->list);
		kfree(msl);
		kzfree(msl);
	}

	list_for_each_entry_safe(dev, dn, &sec->table.devices, list) {
@@ -72,7 +72,7 @@ void mac802154_llsec_destroy(struct mac802154_llsec *sec)
		mkey = container_of(key->key, struct mac802154_llsec_key, key);
		list_del(&key->list);
		llsec_key_put(mkey);
		kfree(key);
		kzfree(key);
	}
}

@@ -161,7 +161,7 @@ llsec_key_alloc(const struct ieee802154_llsec_key *template)
		if (key->tfm[i])
			crypto_free_aead(key->tfm[i]);

	kfree(key);
	kzfree(key);
	return NULL;
}

@@ -176,7 +176,7 @@ static void llsec_key_release(struct kref *ref)
		crypto_free_aead(key->tfm[i]);

	crypto_free_blkcipher(key->tfm0);
	kfree(key);
	kzfree(key);
}

static struct mac802154_llsec_key*
@@ -267,7 +267,7 @@ int mac802154_llsec_key_add(struct mac802154_llsec *sec,
	return 0;

fail:
	kfree(new);
	kzfree(new);
	return -ENOMEM;
}

@@ -347,10 +347,10 @@ static void llsec_dev_free(struct mac802154_llsec_device *dev)
				      devkey);

		list_del(&pos->list);
		kfree(devkey);
		kzfree(devkey);
	}

	kfree(dev);
	kzfree(dev);
}

int mac802154_llsec_dev_add(struct mac802154_llsec *sec,
@@ -681,7 +681,7 @@ llsec_do_encrypt_auth(struct sk_buff *skb, const struct mac802154_llsec *sec,

	rc = crypto_aead_encrypt(req);

	kfree(req);
	kzfree(req);

	return rc;
}
@@ -881,7 +881,7 @@ llsec_do_decrypt_auth(struct sk_buff *skb, const struct mac802154_llsec *sec,

	rc = crypto_aead_decrypt(req);

	kfree(req);
	kzfree(req);
	skb_trim(skb, skb->len - authlen);

	return rc;
@@ -921,7 +921,7 @@ llsec_update_devkey_record(struct mac802154_llsec_device *dev,
		if (!devkey)
			list_add_rcu(&next->devkey.list, &dev->dev.keys);
		else
			kfree(next);
			kzfree(next);

		spin_unlock_bh(&dev->lock);
	}