Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 714cc27d authored by Laurentiu Tudor's avatar Laurentiu Tudor Committed by Greg Kroah-Hartman
Browse files

staging: fsl-mc: move comparison before strcmp() call 



Move comparison before the strcmp() in this if statement, and slightly
increase efficiency by not making the strcmp() each time the if gets
evaluated but only when the comparison is true.
This was suggested in a review comment.

Signed-off-by: default avatarLaurentiu Tudor <laurentiu.tudor@nxp.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ce73724d

drivers/staging/fsl-mc/bus/dprc-driver.c

+3 −2
Original line number Diff line number Diff line
@@ -29,8 +29,9 @@ struct dprc_child_objs { 
static bool fsl_mc_device_match(struct fsl_mc_device *mc_dev,

				struct dprc_obj_desc *obj_desc)

{

	return !strcmp(mc_dev->obj_desc.type, obj_desc->type) &&

		mc_dev->obj_desc.id == obj_desc->id;

	return mc_dev->obj_desc.id == obj_desc->id &&

	       !strcmp(mc_dev->obj_desc.type, obj_desc->type);



}



static int __fsl_mc_device_remove_if_not_in_mc(struct device *dev, void *data)