Commit 713c43b3 authored Mar 06, 2017 by Jiri Pirko Committed by David S. Miller Mar 08, 2017

mlxsw: spectrum_flower: Remove bogus warns in mlxsw_sp_flower_destroy



This warnings may be hit even in case they should not - in case user
puts a TC-flower rule which failed to be offloaded. So just remove them.

Reported-by: Petr Machata <petrm@mellanox.com>
Reported-by: Ido Schimmel <idosch@mellanox.com>
Fixes: commit 7aa0f5aa ("mlxsw: spectrum: Implement TC flower offload")
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Acked-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent f7887d40

drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -303,11 +303,11 @@ void mlxsw_sp_flower_destroy(struct mlxsw_sp_port *mlxsw_sp_port, bool ingress,
		ruleset = mlxsw_sp_acl_ruleset_get(mlxsw_sp, mlxsw_sp_port->dev,
		ingress,
		MLXSW_SP_ACL_PROFILE_FLOWER);
		if (WARN_ON(IS_ERR(ruleset)))
		if (IS_ERR(ruleset))
		return;

		rule = mlxsw_sp_acl_rule_lookup(mlxsw_sp, ruleset, f->cookie);
		if (!WARN_ON(!rule)) {
		if (rule) {
		mlxsw_sp_acl_rule_del(mlxsw_sp, rule);
		mlxsw_sp_acl_rule_destroy(mlxsw_sp, rule);
		}