Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6ff7586e authored by Roman Mashak's avatar Roman Mashak Committed by David S. Miller
Browse files

net sched actions: use sizeof operator for buffer length 



Replace constant integer with sizeof() to clearly indicate
the destination buffer length in skb_header_pointer() calls.

Reviewed-by: default avatarSimon Horman <simon.horman@netronome.com>
Signed-off-by: default avatarRoman Mashak <mrv@mojatatu.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 544377cd

net/sched/act_pedit.c

+2 −2
Original line number Diff line number Diff line
@@ -319,7 +319,7 @@ static int tcf_pedit(struct sk_buff *skb, const struct tc_action *a, 
					goto bad;

				}

				d = skb_header_pointer(skb, hoffset + tkey->at,

						       1, &_d);

						       sizeof(_d), &_d);

				if (!d)

					goto bad;

				offset += (*d & tkey->offmask) >> tkey->shift;
@@ -337,7 +337,7 @@ static int tcf_pedit(struct sk_buff *skb, const struct tc_action *a, 
			}



			ptr = skb_header_pointer(skb, hoffset + offset,

						 4, &hdata);

						 sizeof(hdata), &hdata);

			if (!ptr)

				goto bad;

			/* just do it, baby */