Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6fbe59b9 authored by David S. Miller's avatar David S. Miller
Browse files

[ETHTOOL]: Remove some entries from non-root command list.



GWOL might provide passwords
GSET, GLINK, and GSTATS might poke the hardware

Based upon feedback from Jeff Garzik.

Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 860e13b5
Loading
Loading
Loading
Loading
+0 −4
Original line number Original line Diff line number Diff line
@@ -817,11 +817,8 @@ int dev_ethtool(struct ifreq *ifr)


	/* Allow some commands to be done by anyone */
	/* Allow some commands to be done by anyone */
	switch(ethcmd) {
	switch(ethcmd) {
	case ETHTOOL_GSET:
	case ETHTOOL_GDRVINFO:
	case ETHTOOL_GDRVINFO:
	case ETHTOOL_GWOL:
	case ETHTOOL_GMSGLVL:
	case ETHTOOL_GMSGLVL:
	case ETHTOOL_GLINK:
	case ETHTOOL_GCOALESCE:
	case ETHTOOL_GCOALESCE:
	case ETHTOOL_GRINGPARAM:
	case ETHTOOL_GRINGPARAM:
	case ETHTOOL_GPAUSEPARAM:
	case ETHTOOL_GPAUSEPARAM:
@@ -829,7 +826,6 @@ int dev_ethtool(struct ifreq *ifr)
	case ETHTOOL_GTXCSUM:
	case ETHTOOL_GTXCSUM:
	case ETHTOOL_GSG:
	case ETHTOOL_GSG:
	case ETHTOOL_GSTRINGS:
	case ETHTOOL_GSTRINGS:
	case ETHTOOL_GSTATS:
	case ETHTOOL_GTSO:
	case ETHTOOL_GTSO:
	case ETHTOOL_GPERMADDR:
	case ETHTOOL_GPERMADDR:
	case ETHTOOL_GUFO:
	case ETHTOOL_GUFO: