Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6eeabd8b authored by Colin Ian King's avatar Colin Ian King Committed by Greg Kroah-Hartman
Browse files

staging: media: atomisp: fix range checking on clk_num 



The range checking on clk_num is incorrect; fix these so that invalid
clk_num values are detected correctly.

Detected by static analysis with by PVS-Studio

Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 8ed78a15

drivers/staging/media/atomisp/platform/clock/vlv2_plat_clock.c

+4 −4
Original line number Diff line number Diff line
@@ -67,7 +67,7 @@ int vlv2_plat_set_clock_freq(int clk_num, int freq_type) 
{

	void __iomem *addr;



	if (clk_num < 0 && clk_num > MAX_CLK_COUNT) {

	if (clk_num < 0 || clk_num >= MAX_CLK_COUNT) {

		pr_err("Clock number out of range (%d)\n", clk_num);

		return -EINVAL;

	}
@@ -103,7 +103,7 @@ int vlv2_plat_get_clock_freq(int clk_num) 
{

	u32 ret;



	if (clk_num < 0 && clk_num > MAX_CLK_COUNT) {

	if (clk_num < 0 || clk_num >= MAX_CLK_COUNT) {

		pr_err("Clock number out of range (%d)\n", clk_num);

		return -EINVAL;

	}
@@ -133,7 +133,7 @@ int vlv2_plat_configure_clock(int clk_num, u32 conf) 
{

	void __iomem *addr;



	if (clk_num < 0 && clk_num > MAX_CLK_COUNT) {

	if (clk_num < 0 || clk_num >= MAX_CLK_COUNT) {

		pr_err("Clock number out of range (%d)\n", clk_num);

		return -EINVAL;

	}
@@ -169,7 +169,7 @@ int vlv2_plat_get_clock_status(int clk_num) 
{

	int ret;



	if (clk_num < 0 && clk_num > MAX_CLK_COUNT) {

	if (clk_num < 0 || clk_num >= MAX_CLK_COUNT) {

		pr_err("Clock number out of range (%d)\n", clk_num);

		return -EINVAL;

	}