Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6e78c9fd authored by Arnaldo Carvalho de Melo's avatar Arnaldo Carvalho de Melo
Browse files

perf tui: Remove annotate from popup menu after failure 



Cc: Frédéric Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Stephane Eranian <eranian@google.com>
Cc: Tom Zanussi <tzanussi@gmail.com>
LKML-Reference: <new-submission>
Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 0e8dc259

tools/perf/util/newt.c

+5 −0
Original line number Diff line number Diff line
@@ -914,6 +914,9 @@ int hists__browse(struct hists *self, const char *helpline, const char *input_na 


			switch (toupper(es.u.key)) {

			case 'A':

				if (browser->selection->map == NULL &&

				    browser->selection->map->dso->annotate_warned)

					continue;

				goto do_annotate;

			case 'D':

				goto zoom_dso;
@@ -957,6 +960,7 @@ int hists__browse(struct hists *self, const char *helpline, const char *input_na 
		}



		if (browser->selection->sym != NULL &&

		    !browser->selection->map->dso->annotate_warned &&

		    asprintf(&options[nr_options], "Annotate %s",

			     browser->selection->sym->name) > 0)

			annotate = nr_options++;
@@ -991,6 +995,7 @@ int hists__browse(struct hists *self, const char *helpline, const char *input_na 
			struct hist_entry *he;

do_annotate:

			if (browser->selection->map->dso->origin == DSO__ORIG_KERNEL) {

				browser->selection->map->dso->annotate_warned = 1;

				ui_helpline__puts("No vmlinux file found, can't "

						 "annotate with just a "

						 "kallsyms file");