Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6e543595 authored by Archit Taneja's avatar Archit Taneja
Browse files

OMAPDSS: MANAGER: Check LCD related overlay manager parameters 



The LCD related manager configurations are a part of the manager's private data
in APPLY. Pass this to dss_lcd_mgr_config to dss_mgr_check and create a function
to check the validity of some of the configurations.

To check some of the configurations, we require information of interface to
which the manager output is connected. These can be added once interfaces are
represented as an entity.

Signed-off-by: default avatarArchit Taneja <archit@ti.com>
parent f476ae9d

drivers/video/omap2/dss/apply.c

+1 −1
Original line number Diff line number Diff line
@@ -226,7 +226,7 @@ static int dss_check_settings_low(struct omap_overlay_manager *mgr, 
		ois[ovl->id] = oi;

	}



	return dss_mgr_check(mgr, mi, &mp->timings, ois);

	return dss_mgr_check(mgr, mi, &mp->timings, &mp->lcd_config, ois);

}



/*

drivers/video/omap2/dss/dss.h

+1 −0
Original line number Diff line number Diff line
@@ -244,6 +244,7 @@ int dss_mgr_check_timings(struct omap_overlay_manager *mgr, 
int dss_mgr_check(struct omap_overlay_manager *mgr,

		struct omap_overlay_manager_info *info,

		const struct omap_video_timings *mgr_timings,

		const struct dss_lcd_mgr_config *config,

		struct omap_overlay_info **overlay_infos);



static inline bool dss_mgr_is_lcd(enum omap_channel id)

drivers/video/omap2/dss/manager.c

+35 −0
Original line number Diff line number Diff line
@@ -665,9 +665,40 @@ int dss_mgr_check_timings(struct omap_overlay_manager *mgr, 
	return 0;

}



static int dss_mgr_check_lcd_config(struct omap_overlay_manager *mgr,

		const struct dss_lcd_mgr_config *config)

{

	struct dispc_clock_info cinfo = config->clock_info;

	int dl = config->video_port_width;

	bool stallmode = config->stallmode;

	bool fifohandcheck = config->fifohandcheck;



	if (cinfo.lck_div < 1 || cinfo.lck_div > 255)

		return -EINVAL;



	if (cinfo.pck_div < 1 || cinfo.pck_div > 255)

		return -EINVAL;



	if (dl != 12 && dl != 16 && dl != 18 && dl != 24)

		return -EINVAL;



	/* fifohandcheck should be used only with stallmode */

	if (stallmode == false && fifohandcheck == true)

		return -EINVAL;



	/*

	 * io pad mode can be only checked by using dssdev connected to the

	 * manager. Ignore checking these for now, add checks when manager

	 * is capable of holding information related to the connected interface

	 */



	return 0;

}



int dss_mgr_check(struct omap_overlay_manager *mgr,

		struct omap_overlay_manager_info *info,

		const struct omap_video_timings *mgr_timings,

		const struct dss_lcd_mgr_config *lcd_config,

		struct omap_overlay_info **overlay_infos)

{

	struct omap_overlay *ovl;
@@ -683,6 +714,10 @@ int dss_mgr_check(struct omap_overlay_manager *mgr, 
	if (r)

		return r;



	r = dss_mgr_check_lcd_config(mgr, lcd_config);

	if (r)

		return r;



	list_for_each_entry(ovl, &mgr->overlays, list) {

		struct omap_overlay_info *oi;

		int r;