Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6e1d9d04 authored by YOSHIFUJI Hideaki's avatar YOSHIFUJI Hideaki Committed by David S. Miller
Browse files

[IPV6] HASHTABLES: Use appropriate seed for caluculating ehash index. 



Tetsuo Handa <handat@pm.nttdata.co.jp> told me that connect(2) with TCPv6
socket almost always took a few minutes to return when we did not have any
ports available in the range of net.ipv4.ip_local_port_range.

The reason was that we used incorrect seed for calculating index of
hash when we check established sockets in __inet6_check_established().

Signed-off-by: default avatarYOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ec2f9d13

net/ipv6/inet6_hashtables.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -172,7 +172,7 @@ static int __inet6_check_established(struct inet_timewait_death_row *death_row, 
	const struct in6_addr *saddr = &np->daddr;

	const struct in6_addr *saddr = &np->daddr;

	const int dif = sk->sk_bound_dev_if;

	const int dif = sk->sk_bound_dev_if;

	const __portpair ports = INET_COMBINED_PORTS(inet->dport, lport);

	const __portpair ports = INET_COMBINED_PORTS(inet->dport, lport);

	const unsigned int hash = inet6_ehashfn(daddr, inet->num, saddr,

	const unsigned int hash = inet6_ehashfn(daddr, lport, saddr,

						inet->dport);

						inet->dport);

	struct inet_ehash_bucket *head = inet_ehash_bucket(hinfo, hash);

	struct inet_ehash_bucket *head = inet_ehash_bucket(hinfo, hash);

	struct sock *sk2;

	struct sock *sk2;