Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6dc9b455 authored by Laurent Pinchart's avatar Laurent Pinchart
Browse files

sh-pfc: Return an error if a pin doesn't support the requested direction 



When setting a pin direction verify that the requested direction is
supported, and return an error if it isn't.

This requires pin configuration information to be supplied by SoC data.
The check is a no-op if the information is not supplied.

Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Acked-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 9a643c9a

drivers/pinctrl/sh-pfc/pinctrl.c

+10 −0
Original line number Diff line number Diff line
@@ -218,8 +218,18 @@ static int sh_pfc_gpio_set_direction(struct pinctrl_dev *pctldev, 
	const struct sh_pfc_pin *pin = &pfc->info->pins[idx];

	struct sh_pfc_pin_config *cfg = &pmx->configs[idx];

	unsigned long flags;

	unsigned int dir;

	int ret;



	/* Check if the requested direction is supported by the pin. Not all SoC

	 * provide pin config data, so perform the check conditionally.

	 */

	if (pin->configs) {

		dir = input ? SH_PFC_PIN_CFG_INPUT : SH_PFC_PIN_CFG_OUTPUT;

		if (!(pin->configs & dir))

			return -EINVAL;

	}



	spin_lock_irqsave(&pfc->lock, flags);



	ret = sh_pfc_config_mux(pfc, pin->enum_id, new_type);