Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6d7a2b8b authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Linus Walleij
Browse files

gpio: xgene-sb: Don't shadow error code of gpiochip_lock_as_irq() 



gpiochip_lock_as_irq() may return a few error codes,
do not shadow them by -ENOSPC and let caller to decide.

No functional change intended.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 41d69087

drivers/gpio/gpio-xgene-sb.c

+4 −2
Original line number Original line Diff line number Diff line
@@ -143,12 +143,14 @@ static int xgene_gpio_sb_domain_activate(struct irq_domain *d, 
{

{

	struct xgene_gpio_sb *priv = d->host_data;

	struct xgene_gpio_sb *priv = d->host_data;

	u32 gpio = HWIRQ_TO_GPIO(priv, irq_data->hwirq);

	u32 gpio = HWIRQ_TO_GPIO(priv, irq_data->hwirq);

	int ret;





	if (gpiochip_lock_as_irq(&priv->gc, gpio)) {

	ret = gpiochip_lock_as_irq(&priv->gc, gpio);

	if (ret) {

		dev_err(priv->gc.parent,

		dev_err(priv->gc.parent,

		"Unable to configure XGene GPIO standby pin %d as IRQ\n",

		"Unable to configure XGene GPIO standby pin %d as IRQ\n",

				gpio);

				gpio);

		return -ENOSPC;

		return ret;

	}

	}





	xgene_gpio_set_bit(&priv->gc, priv->regs + MPA_GPIO_SEL_LO,

	xgene_gpio_set_bit(&priv->gc, priv->regs + MPA_GPIO_SEL_LO,