Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6d0f41ab authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

USB: mos7720: remove incorrect read-urb check



Remove incorrect and unnecessary check for port->read_urb which is not
set to NULL, contrary to what seems to be assumed, when urb is killed.

Compile only-tested.

Signed-off-by: default avatarJohan Hovold <jhovold@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 4556143c
Loading
Loading
Loading
Loading
+0 −10
Original line number Original line Diff line number Diff line
@@ -939,11 +939,6 @@ static void mos7720_bulk_in_callback(struct urb *urb)
	}
	}
	tty_kref_put(tty);
	tty_kref_put(tty);


	if (!port->read_urb) {
		dbg("URB KILLED !!!");
		return;
	}

	if (port->read_urb->status != -EINPROGRESS) {
	if (port->read_urb->status != -EINPROGRESS) {
		port->read_urb->dev = port->serial->dev;
		port->read_urb->dev = port->serial->dev;


@@ -1786,11 +1781,6 @@ static void mos7720_set_termios(struct tty_struct *tty,
	/* change the port settings to the new ones specified */
	/* change the port settings to the new ones specified */
	change_port_settings(tty, mos7720_port, old_termios);
	change_port_settings(tty, mos7720_port, old_termios);


	if (!port->read_urb) {
		dbg("%s", "URB KILLED !!!!!");
		return;
	}

	if (port->read_urb->status != -EINPROGRESS) {
	if (port->read_urb->status != -EINPROGRESS) {
		port->read_urb->dev = serial->dev;
		port->read_urb->dev = serial->dev;
		status = usb_submit_urb(port->read_urb, GFP_ATOMIC);
		status = usb_submit_urb(port->read_urb, GFP_ATOMIC);