Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6c0f8bc7 authored by Stoyan Gaydarov's avatar Stoyan Gaydarov Committed by David S. Miller
Browse files

sbus: changed ioctls to unlocked 



Signed-off-by: default avatarStoyan Gaydarov <stoyboyker@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c7cb1521

drivers/sbus/char/jsflash.c

+10 −5
Original line number Diff line number Diff line
@@ -383,18 +383,22 @@ static int jsf_ioctl_program(void __user *arg) 
	return 0;

}



static int jsf_ioctl(struct inode *inode, struct file *f, unsigned int cmd,

    unsigned long arg)

static long jsf_ioctl(struct file *f, unsigned int cmd, unsigned long arg)

{

	lock_kernel();

	int error = -ENOTTY;

	void __user *argp = (void __user *)arg;



	if (!capable(CAP_SYS_ADMIN))

	if (!capable(CAP_SYS_ADMIN)) {

		unlock_kernel();

		return -EPERM;

	}

	switch (cmd) {

	case JSFLASH_IDENT:

		if (copy_to_user(argp, &jsf0.id, JSFIDSZ))

		if (copy_to_user(argp, &jsf0.id, JSFIDSZ)) {

			unlock_kernel();

			return -EFAULT;

		}

		break;

	case JSFLASH_ERASE:

		error = jsf_ioctl_erase(arg);
@@ -404,6 +408,7 @@ static int jsf_ioctl(struct inode *inode, struct file *f, unsigned int cmd, 
		break;

	}



	unlock_kernel();

	return error;

}
@@ -439,7 +444,7 @@ static const struct file_operations jsf_fops = { 
	.llseek =	jsf_lseek,

	.read =		jsf_read,

	.write =	jsf_write,

	.ioctl =	jsf_ioctl,

	.unlocked_ioctl =	jsf_ioctl,

	.mmap =		jsf_mmap,

	.open =		jsf_open,

	.release =	jsf_release,

drivers/sbus/char/uctrl.c

+3 −4
Original line number Diff line number Diff line
@@ -197,9 +197,8 @@ static struct uctrl_driver { 
static void uctrl_get_event_status(struct uctrl_driver *);

static void uctrl_get_external_status(struct uctrl_driver *);



static int

uctrl_ioctl(struct inode *inode, struct file *file,

	      unsigned int cmd, unsigned long arg)

static long

uctrl_ioctl(struct file *file, unsigned int cmd, unsigned long arg)

{

	switch (cmd) {

		default:
@@ -226,7 +225,7 @@ static irqreturn_t uctrl_interrupt(int irq, void *dev_id) 
static const struct file_operations uctrl_fops = {

	.owner =	THIS_MODULE,

	.llseek =	no_llseek,

	.ioctl =	uctrl_ioctl,

	.unlocked_ioctl =	uctrl_ioctl,

	.open =		uctrl_open,

};