Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6b04e9f2 authored by Markus Elfring's avatar Markus Elfring Committed by Bartlomiej Zolnierkiewicz
Browse files

video/fbdev/dnfb: Use common error handling code in dnfb_probe() 



Add a jump target so that a bit of exception handling can be better reused
at the end of this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
parent ffb66624

drivers/video/fbdev/dnfb.c

+7 −6
Original line number Diff line number Diff line
@@ -242,16 +242,13 @@ static int dnfb_probe(struct platform_device *dev) 
	info->screen_base = (u_char *) info->fix.smem_start;



	err = fb_alloc_cmap(&info->cmap, 2, 0);

	if (err < 0) {

		framebuffer_release(info);

		return err;

	}

	if (err < 0)

		goto release_framebuffer;



	err = register_framebuffer(info);

	if (err < 0) {

		fb_dealloc_cmap(&info->cmap);

		framebuffer_release(info);

		return err;

		goto release_framebuffer;

	}

	platform_set_drvdata(dev, info);
@@ -265,6 +262,10 @@ static int dnfb_probe(struct platform_device *dev) 


	printk("apollo frame buffer alive and kicking !\n");

	return err;



release_framebuffer:

	framebuffer_release(info);

	return err;

}



static struct platform_driver dnfb_driver = {