Commit 6ad37567 authored Oct 21, 2016 by Martyn Welch Committed by Greg Kroah-Hartman Oct 28, 2016

vme: vme_get_size potentially returning incorrect value on failure



The function vme_get_size returns the size of the window to the caller,
however it doesn't check the return value of the call to vme_master_get.

Return 0 on failure rather than anything else.

Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Martyn Welch <martyn.welch@collabora.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent cfcc1456

drivers/vme/vme.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -156,12 +156,16 @@ size_t vme_get_size(struct vme_resource *resource)
		case VME_MASTER:
		retval = vme_master_get(resource, &enabled, &base, &size,
		&aspace, &cycle, &dwidth);
		if (retval)
		return 0;

		return size;
		break;
		case VME_SLAVE:
		retval = vme_slave_get(resource, &enabled, &base, &size,
		&buf_base, &aspace, &cycle);
		if (retval)
		return 0;

		return size;
		break;