Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 69c3683c authored by Keiichi KII's avatar Keiichi KII Committed by David S. Miller
Browse files

netconsole: avoid null pointer dereference at show_local_mac() 



This patch avoids a null pointer dereference when we read local_mac 
for netconsole in configfs and shows default local mac address
value.

A null pointer dereference occurs when we call show_local_mac() via 
local_mac entry in configfs before we setup the content of netpoll
using netpoll_setup().

Signed-off-by: default avatarKeiichi KII <k-keiichi@bx.jp.nec.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b5c15fc0

drivers/net/netconsole.c

+2 −2
Original line number Diff line number Diff line
@@ -309,8 +309,8 @@ static ssize_t show_local_mac(struct netconsole_target *nt, char *buf) 
	struct net_device *dev = nt->np.dev;



	DECLARE_MAC_BUF(mac);

	return snprintf(buf, PAGE_SIZE, "%s\n",

			print_mac(mac, dev->dev_addr));

	return snprintf(buf, PAGE_SIZE, "%s\n", dev ?

			print_mac(mac, dev->dev_addr) : "ff:ff:ff:ff:ff:ff");

}



static ssize_t show_remote_mac(struct netconsole_target *nt, char *buf)