Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6995de21 authored by Gustavo Pimentel's avatar Gustavo Pimentel Committed by Lorenzo Pieralisi
Browse files

PCI: dwc: Small computation improvement 



Replace a division by 2 operation for a right shift rotation of 1 bit.

Probably any recent and decent compiler does this kind of substitution
in order to improve code performance. Nevertheless it's a coding good
practice whenever there is a division / multiplication by multiple of 2
to replace it by the equivalent operation in this case, the shift
rotation.

Signed-off-by: default avatarGustavo Pimentel <gustavo.pimentel@synopsys.com>
Signed-off-by: default avatarLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Acked-by: default avatarJingoo Han <jingoohan1@gmail.com>
Acked-by: default avatarJoao Pinto <jpinto@synopsys.com>
parent b4a8a51c

drivers/pci/dwc/pcie-designware-host.c

+4 −4
Original line number Original line Diff line number Diff line
@@ -332,8 +332,8 @@ int dw_pcie_host_init(struct pcie_port *pp) 




	cfg_res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "config");

	cfg_res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "config");

	if (cfg_res) {

	if (cfg_res) {

		pp->cfg0_size = resource_size(cfg_res) / 2;

		pp->cfg0_size = resource_size(cfg_res) >> 1;

		pp->cfg1_size = resource_size(cfg_res) / 2;

		pp->cfg1_size = resource_size(cfg_res) >> 1;

		pp->cfg0_base = cfg_res->start;

		pp->cfg0_base = cfg_res->start;

		pp->cfg1_base = cfg_res->start + pp->cfg0_size;

		pp->cfg1_base = cfg_res->start + pp->cfg0_size;

	} else if (!pp->va_cfg0_base) {

	} else if (!pp->va_cfg0_base) {
@@ -377,8 +377,8 @@ int dw_pcie_host_init(struct pcie_port *pp) 
			break;

			break;

		case 0:

		case 0:

			pp->cfg = win->res;

			pp->cfg = win->res;

			pp->cfg0_size = resource_size(pp->cfg) / 2;

			pp->cfg0_size = resource_size(pp->cfg) >> 1;

			pp->cfg1_size = resource_size(pp->cfg) / 2;

			pp->cfg1_size = resource_size(pp->cfg) >> 1;

			pp->cfg0_base = pp->cfg->start;

			pp->cfg0_base = pp->cfg->start;

			pp->cfg1_base = pp->cfg->start + pp->cfg0_size;

			pp->cfg1_base = pp->cfg->start + pp->cfg0_size;

			break;

			break;