Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6977a79d authored by Igor Maravic's avatar Igor Maravic Committed by David S. Miller
Browse files

net: Fix skb_update_prio RCU usage. 



Change function rcu_dereference to rcu_dereference_bh to avoid warning

[ INFO: suspicious RCU usage. ]
-------------------------------
net/core/dev.c:2459 suspicious rcu_dereference_check() usage!

because we are locking with

rcu_read_lock_bh();

in function dev_queue_xmit(struct sk_buff *skb)

Signed-off-by: default avatarIgor Maravic <igorm@etf.rs>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2bcc34bb

net/core/dev.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -2473,7 +2473,7 @@ static inline int __dev_xmit_skb(struct sk_buff *skb, struct Qdisc *q, 
#if IS_ENABLED(CONFIG_NETPRIO_CGROUP)

#if IS_ENABLED(CONFIG_NETPRIO_CGROUP)

static void skb_update_prio(struct sk_buff *skb)

static void skb_update_prio(struct sk_buff *skb)

{

{

	struct netprio_map *map = rcu_dereference(skb->dev->priomap);

	struct netprio_map *map = rcu_dereference_bh(skb->dev->priomap);





	if ((!skb->priority) && (skb->sk) && map)

	if ((!skb->priority) && (skb->sk) && map)

		skb->priority = map->priomap[skb->sk->sk_cgrp_prioidx];

		skb->priority = map->priomap[skb->sk->sk_cgrp_prioidx];