Commit 69166d25 authored Nov 09, 2015 by Viresh Kumar Committed by Greg Kroah-Hartman Nov 12, 2015

greybus: es2: Send cport-id in wValue field to usb_control_msg()



wIndex field has a special meaning, as that can be used by the core to
index into the possible USB interfaces. And that specifically broke with
gbsim, as it has a single USB interface.

Other similar requests (REQUEST_LATENCY_TAG_{EN|DIS}) are already using
wValue field for passing cport-id.

Fix cport_reset() by sending the cport-id in wValue field instead of
wIndex.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Tested-by: Fabien Parent <fparent@baylibre.com>
Reviewed-by: Johan Hovold <johan@hovoldconsulting.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>

parent f6c6c138

drivers/staging/greybus/es2.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -440,7 +440,7 @@ static int cport_reset(struct gb_host_device *hd, u16 cport_id)
		retval = usb_control_msg(udev, usb_sndctrlpipe(udev, 0),
		REQUEST_RESET_CPORT,
		USB_DIR_OUT \| USB_TYPE_VENDOR \|
		USB_RECIP_INTERFACE, 0, cport_id,
		USB_RECIP_INTERFACE, cport_id, 0,
		NULL, 0, ES2_TIMEOUT);
		if (retval < 0) {
		dev_err(&udev->dev, "failed to reset cport %hu: %d\n", cport_id,