Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 68581446 authored by Shuah Khan (Samsung OSG)'s avatar Shuah Khan (Samsung OSG)
Browse files

selftests: zram: return Kselftest Skip code for skipped tests 



When zram test is skipped because of unmet dependencies and/or
unsupported configuration, it exits with error which is treated as
a fail by the Kselftest framework. This leads to false negative result
even when the test could not be run.

Change it to return kselftest skip code when a test gets skipped to
clearly report that the test could not be run.

Kselftest framework SKIP code is 4 and the framework prints appropriate
messages to indicate that the test is skipped.

Signed-off-by: default avatarShuah Khan (Samsung OSG) <shuah@kernel.org>
parent d7d5311d

tools/testing/selftests/zram/zram.sh

+4 −1
Original line number Diff line number Diff line
@@ -2,6 +2,9 @@ 
# SPDX-License-Identifier: GPL-2.0

TCID="zram.sh"



# Kselftest framework requirement - SKIP code is 4.

ksft_skip=4



. ./zram_lib.sh



run_zram () {
@@ -24,5 +27,5 @@ elif [ -b /dev/zram0 ]; then 
else

	echo "$TCID : No zram.ko module or /dev/zram0 device file not found"

	echo "$TCID : CONFIG_ZRAM is not set"

	exit 1

	exit $ksft_skip

fi

tools/testing/selftests/zram/zram_lib.sh

+4 −1
Original line number Diff line number Diff line
@@ -18,6 +18,9 @@ MODULE=0 
dev_makeswap=-1

dev_mounted=-1



# Kselftest framework requirement - SKIP code is 4.

ksft_skip=4



trap INT



check_prereqs()
@@ -27,7 +30,7 @@ check_prereqs() 


	if [ $uid -ne 0 ]; then

		echo $msg must be run as root >&2

		exit 0

		exit $ksft_skip

	fi

}