Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6851d025 authored by Heiner Kallweit's avatar Heiner Kallweit Committed by David S. Miller
Browse files

r8169: remove unneeded check in r8168_pll_power_down 



RTL_GIGA_MAC_VER_23/24 are configured by rtl_hw_start_8168cp_2()
and rtl_hw_start_8168cp_3() respectively which both apply
CPCMD_QUIRK_MASK, thus clearing bit ASF.

Bit ASF isn't set at any other place in the driver, therefore this
check can be removed.

Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 77ec3a0e

drivers/net/ethernet/realtek/r8169.c

+0 −6
Original line number Diff line number Diff line
@@ -4838,12 +4838,6 @@ static void r8168_pll_power_down(struct rtl8169_private *tp) 
	if (r8168_check_dash(tp))

		return;



	if ((tp->mac_version == RTL_GIGA_MAC_VER_23 ||

	     tp->mac_version == RTL_GIGA_MAC_VER_24) &&

	    (tp->cp_cmd & ASF)) {

		return;

	}



	if (tp->mac_version == RTL_GIGA_MAC_VER_32 ||

	    tp->mac_version == RTL_GIGA_MAC_VER_33)

		rtl_ephy_write(tp, 0x19, 0xff64);