Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 682e852e authored Jan 10, 2006 by Alexey Dobriyan Committed by Linus Torvalds Jan 09, 2006

[PATCH] Fix more "if ((err = foo() < 0))" typos



Another reason to use:

	ret = foo();
	if (ret < 0)
		goto out;

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent 41ed16fa

Documentation/kprobes.txt

+2 −1

Original line number	Diff line number	Diff line
		@@ -411,7 +411,8 @@ int init_module(void)
		printk("Couldn't find %s to plant kprobe\n", "do_fork");
		return -1;
		}
		if ((ret = register_kprobe(&kp) < 0)) {
		ret = register_kprobe(&kp);
		if (ret < 0) {
		printk("register_kprobe failed, returned %d\n", ret);
		return -1;
		}

arch/mips/kernel/vpe.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -1171,7 +1171,8 @@ static int __init vpe_module_init(void)
		return -ENODEV;
		}

		if ((major = register_chrdev(0, module_name, &vpe_fops) < 0)) {
		major = register_chrdev(0, module_name, &vpe_fops);
		if (major < 0) {
		printk("VPE loader: unable to register character device\n");
		return major;
		}

drivers/media/dvb/frontends/mt312.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -501,7 +501,8 @@ static int mt312_set_frontend(struct dvb_frontend* fe,
		case ID_VP310:
		// For now we will do this only for the VP310.
		// It should be better for the mt312 as well, but tunning will be slower. ACCJr 09/29/03
		if ((ret = mt312_readreg(state, CONFIG, &config_val) < 0))
		ret = mt312_readreg(state, CONFIG, &config_val);
		if (ret < 0)
		return ret;
		if (p->u.qpsk.symbol_rate >= 30000000) //Note that 30MS/s should use 90MHz
		{