Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 672af843 authored by Bob Moore's avatar Bob Moore Committed by Len Brown
Browse files

ACPICA: Debugger: Lock namespace for duration of a namespace dump 



Prevents issues if the namespace is changing underneath the
debugger.  Especially temporary nodes, since the debugger displays
these also.

Signed-off-by: default avatarBob Moore <robert.moore@intel.com>
Signed-off-by: default avatarLin Ming <ming.m.lin@intel.com>
Reviewed-by: default avatarRafael Wysocki <rjw@sisk.pl>
Signed-off-by: default avatarLen Brown <len.brown@intel.com>
parent 5d3131f5

drivers/acpi/acpica/nsdump.c

+15 −0
Original line number Diff line number Diff line
@@ -624,9 +624,22 @@ acpi_ns_dump_objects(acpi_object_type type, 
		     acpi_owner_id owner_id, acpi_handle start_handle)

{

	struct acpi_walk_info info;

	acpi_status status;



	ACPI_FUNCTION_ENTRY();



	/*

	 * Just lock the entire namespace for the duration of the dump.

	 * We don't want any changes to the namespace during this time,

	 * especially the temporary nodes since we are going to display

	 * them also.

	 */

	status = acpi_ut_acquire_mutex(ACPI_MTX_NAMESPACE);

	if (ACPI_FAILURE(status)) {

		acpi_os_printf("Could not acquire namespace mutex\n");

		return;

	}



	info.debug_level = ACPI_LV_TABLES;

	info.owner_id = owner_id;

	info.display_type = display_type;
@@ -636,6 +649,8 @@ acpi_ns_dump_objects(acpi_object_type type, 
				     ACPI_NS_WALK_TEMP_NODES,

				     acpi_ns_dump_one_object, NULL,

				     (void *)&info, NULL);



	(void)acpi_ut_release_mutex(ACPI_MTX_NAMESPACE);

}

#endif				/* ACPI_FUTURE_USAGE */