Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 65b01665 authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab
Browse files

[media] cx24120: don't initialize a var that won't be used 



As reported by smatch:
drivers/media/dvb-frontends/cx24120.c: In function 'cx24120_message_send':
drivers/media/dvb-frontends/cx24120.c:368:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
  int ret, ficus;
      ^

The values written by cx24120 are never checked. So, remove the
check here too. That's said, the best would be to do the reverse,
but globally: to properly handle the error codes.

Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
Signed-off-by: default avatarPatrick Boettcher <patrick.boettcher@posteo.de>
parent 5c0a1c28

drivers/media/dvb-frontends/cx24120.c

+5 −5
Original line number Diff line number Diff line
@@ -365,17 +365,17 @@ static void cx24120_check_cmd(struct cx24120_state *state, u8 id) 
static int cx24120_message_send(struct cx24120_state *state,

				struct cx24120_cmd *cmd)

{

	int ret, ficus;

	int ficus;



	if (state->mpeg_enabled) {

		/* Disable mpeg out on certain commands */

		cx24120_check_cmd(state, cmd->id);

	}



	ret = cx24120_writereg(state, CX24120_REG_CMD_START, cmd->id);

	ret = cx24120_writeregs(state, CX24120_REG_CMD_ARGS, &cmd->arg[0],

	cx24120_writereg(state, CX24120_REG_CMD_START, cmd->id);

	cx24120_writeregs(state, CX24120_REG_CMD_ARGS, &cmd->arg[0],

			  cmd->len, 1);

	ret = cx24120_writereg(state, CX24120_REG_CMD_END, 0x01);

	cx24120_writereg(state, CX24120_REG_CMD_END, 0x01);



	ficus = 1000;

	while (cx24120_readreg(state, CX24120_REG_CMD_END)) {