Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 63d5be0f authored by Mike Christie's avatar Mike Christie Committed by Martin K. Petersen
Browse files

scsi: tcmu: use lio core se_device configuration helper 



Use the lio core helper to check if the device is configured.

Signed-off-by: default avatarMike Christie <mchristi@redhat.com>
Reviewed-by: default avatarXiubo Li <xiubli@redhat.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent cb0f32e1

drivers/target/target_core_user.c

+3 −8
Original line number Diff line number Diff line
@@ -1908,11 +1908,6 @@ static int tcmu_configure_device(struct se_device *dev) 
	return ret;

}



static bool tcmu_dev_configured(struct tcmu_dev *udev)

{

	return udev->uio_info.uio_dev ? true : false;

}



static void tcmu_free_device(struct se_device *dev)

{

	struct tcmu_dev *udev = TCMU_DEV(dev);
@@ -2305,7 +2300,7 @@ static ssize_t tcmu_dev_config_store(struct config_item *item, const char *page, 
		return -EINVAL;



	/* Check if device has been configured before */

	if (tcmu_dev_configured(udev)) {

	if (target_dev_configured(&udev->se_dev)) {

		ret = tcmu_send_dev_config_event(udev, page);

		if (ret) {

			pr_err("Unable to reconfigure device\n");
@@ -2367,7 +2362,7 @@ static ssize_t tcmu_dev_size_store(struct config_item *item, const char *page, 
		return ret;



	/* Check if device has been configured before */

	if (tcmu_dev_configured(udev)) {

	if (target_dev_configured(&udev->se_dev)) {

		ret = tcmu_send_dev_size_event(udev, val);

		if (ret) {

			pr_err("Unable to reconfigure device\n");
@@ -2449,7 +2444,7 @@ static ssize_t tcmu_emulate_write_cache_store(struct config_item *item, 
		return ret;



	/* Check if device has been configured before */

	if (tcmu_dev_configured(udev)) {

	if (target_dev_configured(&udev->se_dev)) {

		ret = tcmu_send_emulate_write_cache(udev, val);

		if (ret) {

			pr_err("Unable to reconfigure device\n");