Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 63c9b9d3 authored by Jingoo Han's avatar Jingoo Han Committed by Greg Kroah-Hartman
Browse files

USB: ohci-ppc-of: use dev_err() instead of printk() 



Use dev_err() instead of printk() to provide a better message
to userspace.

Signed-off-by: default avatarJingoo Han <jg1.han@samsung.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 0a3aa0d3

drivers/usb/host/ohci-ppc-of.c

+5 −3
Original line number Original line Diff line number Diff line
@@ -116,21 +116,23 @@ static int ohci_hcd_ppc_of_probe(struct platform_device *op) 
	hcd->rsrc_len = resource_size(&res);

	hcd->rsrc_len = resource_size(&res);





	if (!request_mem_region(hcd->rsrc_start, hcd->rsrc_len, hcd_name)) {

	if (!request_mem_region(hcd->rsrc_start, hcd->rsrc_len, hcd_name)) {

		printk(KERN_ERR "%s: request_mem_region failed\n", __FILE__);

		dev_err(&op->dev, "%s: request_mem_region failed\n",

			__FILE__);

		rv = -EBUSY;

		rv = -EBUSY;

		goto err_rmr;

		goto err_rmr;

	}

	}





	irq = irq_of_parse_and_map(dn, 0);

	irq = irq_of_parse_and_map(dn, 0);

	if (irq == NO_IRQ) {

	if (irq == NO_IRQ) {

		printk(KERN_ERR "%s: irq_of_parse_and_map failed\n", __FILE__);

		dev_err(&op->dev, "%s: irq_of_parse_and_map failed\n",

			__FILE__);

		rv = -EBUSY;

		rv = -EBUSY;

		goto err_irq;

		goto err_irq;

	}

	}





	hcd->regs = ioremap(hcd->rsrc_start, hcd->rsrc_len);

	hcd->regs = ioremap(hcd->rsrc_start, hcd->rsrc_len);

	if (!hcd->regs) {

	if (!hcd->regs) {

		printk(KERN_ERR "%s: ioremap failed\n", __FILE__);

		dev_err(&op->dev, "%s: ioremap failed\n", __FILE__);

		rv = -ENOMEM;

		rv = -ENOMEM;

		goto err_ioremap;

		goto err_ioremap;

	}

	}