Commit 6286ef9b authored Jul 19, 2013 by Dan Carpenter Committed by Daniel Vetter Jul 19, 2013

drm/i915: use after free on error path



i915_gem_vma_destroy() frees its argument so we have to move the
drm_mm_remove_node() call up a few lines.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

parent db473b36

drivers/gpu/drm/i915/i915_gem.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -3182,9 +3182,9 @@ i915_gem_object_bind_to_gtt(struct drm_i915_gem_object *obj,
		return 0;

		err_out:
		drm_mm_remove_node(&vma->node);
		i915_gem_vma_destroy(vma);
		i915_gem_object_unpin_pages(obj);
		drm_mm_remove_node(&vma->node);
		return ret;
		}