Commit 6217e5ed authored Jul 16, 2014 by Dan Carpenter Committed by Takashi Iwai Jul 16, 2014

ALSA: compress: fix an integer overflow check



I previously added an integer overflow check here but looking at it now,
it's still buggy.

The bug happens in snd_compr_allocate_buffer().  We multiply
".fragments" and ".fragment_size" and that doesn't overflow but then we
save it in an unsigned int so it truncates the high bits away and we
allocate a smaller than expected size.

Fixes: b35cc822 ('ALSA: compress_core: integer overflow in snd_compr_allocate_buffer()')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent 892028ac

sound/core/compress_offload.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -491,7 +491,7 @@ static int snd_compress_check_input(struct snd_compr_params *params)
		{
		/* first let's check the buffer parameter's */
		if (params->buffer.fragment_size == 0 \|\|
		params->buffer.fragments > SIZE_MAX / params->buffer.fragment_size)
		params->buffer.fragments > INT_MAX / params->buffer.fragment_size)
		return -EINVAL;

		/* now codec parameters */