Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 619c9700 authored by Colin Ian King's avatar Colin Ian King Committed by Kalle Valo
Browse files

ath6kl: remove redundant variables netlen, orig_buf, orig_len, dropped and stats 



Variables netlen, orig_buf, orig_len, dropped and stats are assigned values
but are never used hence they are redundant and can be removed.

Cleans up clang warnings:
warning: variable 'netlen' set but not used [-Wunused-but-set-variable]
warning: variable 'orig_buf' set but not used [-Wunused-but-set-variable]
warning: variable 'orig_len' set but not used [-Wunused-but-set-variable]
warning: variable 'dropped' set but not used [-Wunused-but-set-variable]
warning: variable 'stats' set but not used [-Wunused-but-set-variable]

Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent e8c38062

drivers/net/wireless/ath/ath6kl/htc_pipe.c

+2 −8
Original line number Diff line number Diff line
@@ -746,10 +746,8 @@ static int ath6kl_htc_pipe_tx_complete(struct ath6kl *ar, struct sk_buff *skb) 
	struct htc_endpoint *ep;

	struct htc_packet *packet;

	u8 ep_id, *netdata;

	u32 netlen;



	netdata = skb->data;

	netlen = skb->len;



	htc_hdr = (struct htc_frame_hdr *) netdata;
@@ -855,12 +853,8 @@ static int htc_process_trailer(struct htc_target *target, u8 *buffer, 
{

	struct htc_credit_report *report;

	struct htc_record_hdr *record;

	u8 *record_buf, *orig_buf;

	int orig_len, status;



	orig_buf = buffer;

	orig_len = len;

	status = 0;

	u8 *record_buf;

	int status = 0;



	while (len > 0) {

		if (len < sizeof(struct htc_record_hdr)) {

drivers/net/wireless/ath/ath6kl/main.c

+1 −2
Original line number Diff line number Diff line
@@ -272,7 +272,7 @@ int ath6kl_read_fwlogs(struct ath6kl *ar) 
{

	struct ath6kl_dbglog_hdr debug_hdr;

	struct ath6kl_dbglog_buf debug_buf;

	u32 address, length, dropped, firstbuf, debug_hdr_addr;

	u32 address, length, firstbuf, debug_hdr_addr;

	int ret, loop;

	u8 *buf;
@@ -303,7 +303,6 @@ int ath6kl_read_fwlogs(struct ath6kl *ar) 
	address = TARG_VTOP(ar->target_type,

			    le32_to_cpu(debug_hdr.dbuf_addr));

	firstbuf = address;

	dropped = le32_to_cpu(debug_hdr.dropped);

	ret = ath6kl_diag_read(ar, address, &debug_buf, sizeof(debug_buf));

	if (ret)

		goto out;

drivers/net/wireless/ath/ath6kl/txrx.c

+0 −2
Original line number Diff line number Diff line
@@ -1701,7 +1701,6 @@ void aggr_recv_addba_req_evt(struct ath6kl_vif *vif, u8 tid_mux, u16 seq_no, 
	struct ath6kl_sta *sta;

	struct aggr_info_conn *aggr_conn = NULL;

	struct rxtid *rxtid;

	struct rxtid_stats *stats;

	u16 hold_q_size;

	u8 tid, aid;
@@ -1722,7 +1721,6 @@ void aggr_recv_addba_req_evt(struct ath6kl_vif *vif, u8 tid_mux, u16 seq_no, 
		return;



	rxtid = &aggr_conn->rx_tid[tid];

	stats = &aggr_conn->stat[tid];



	if (win_sz < AGGR_WIN_SZ_MIN || win_sz > AGGR_WIN_SZ_MAX)

		ath6kl_dbg(ATH6KL_DBG_WLAN_RX, "%s: win_sz %d, tid %d\n",