Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 614388ce authored by Michael Chan's avatar Michael Chan Committed by David S. Miller
Browse files

bnxt_en: Determine tcp/ipv6 RSS hash type correctly. 



The profile ID in the completion record needs to be ANDed with the
profile ID mask of 0x1f.  This bug was causing the SKB hash type
and the gso_type to be wrong in some cases.

Signed-off-by: default avatarMichael Chan <mchan@broadcom.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c5d7774d

drivers/net/ethernet/broadcom/bnxt/bnxt.h

+7 −5
Original line number Diff line number Diff line
@@ -166,9 +166,11 @@ struct rx_cmp { 
#define RX_CMP_HASH_VALID(rxcmp)				\

	((rxcmp)->rx_cmp_len_flags_type & cpu_to_le32(RX_CMP_FLAGS_RSS_VALID))



#define RSS_PROFILE_ID_MASK	0x1f



#define RX_CMP_HASH_TYPE(rxcmp)					\

	((le32_to_cpu((rxcmp)->rx_cmp_misc_v1) & RX_CMP_RSS_HASH_TYPE) >>\

	 RX_CMP_RSS_HASH_TYPE_SHIFT)

	(((le32_to_cpu((rxcmp)->rx_cmp_misc_v1) & RX_CMP_RSS_HASH_TYPE) >>\

	  RX_CMP_RSS_HASH_TYPE_SHIFT) & RSS_PROFILE_ID_MASK)



struct rx_cmp_ext {

	__le32 rx_cmp_flags2;
@@ -282,9 +284,9 @@ struct rx_tpa_start_cmp { 
	 cpu_to_le32(RX_TPA_START_CMP_FLAGS_RSS_VALID))



#define TPA_START_HASH_TYPE(rx_tpa_start)				\

	((le32_to_cpu((rx_tpa_start)->rx_tpa_start_cmp_misc_v1) &	\

	(((le32_to_cpu((rx_tpa_start)->rx_tpa_start_cmp_misc_v1) &	\

	   RX_TPA_START_CMP_RSS_HASH_TYPE) >>				\

	 RX_TPA_START_CMP_RSS_HASH_TYPE_SHIFT)

	  RX_TPA_START_CMP_RSS_HASH_TYPE_SHIFT) & RSS_PROFILE_ID_MASK)



#define TPA_START_AGG_ID(rx_tpa_start)					\

	((le32_to_cpu((rx_tpa_start)->rx_tpa_start_cmp_misc_v1) &	\