Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 613e1def authored by Martin Schwidefsky's avatar Martin Schwidefsky
Browse files

[S390] Remove self ptrace IEEE_IP hack. 



The self referential PT_IEEE_IP ptrace peek & poke calls have been
broken for that last 6 years. For peek the code always returns 0
instead of the last ieee fault and for poke the code does nothing.
Since nobody noticed the code seems to be superfluous. So lets
remove it.

Cc: Christoph Hellwig <hch@infradead.org>
Signed-off-by: default avatarMartin Schwidefsky <schwidefsky@de.ibm.com>
parent 17f34580

arch/s390/kernel/ptrace.c

+0 −20
Original line number Diff line number Diff line
@@ -607,8 +607,6 @@ do_ptrace_emu31(struct task_struct *child, long request, long addr, long data) 
}

#endif



#define PT32_IEEE_IP 0x13c



static int

do_ptrace(struct task_struct *child, long request, long addr, long data)

{
@@ -617,24 +615,6 @@ do_ptrace(struct task_struct *child, long request, long addr, long data) 
	if (request == PTRACE_ATTACH)

		return ptrace_attach(child);



	/*

	 * Special cases to get/store the ieee instructions pointer.

	 */

	if (child == current) {

		if (request == PTRACE_PEEKUSR && addr == PT_IEEE_IP)

			return peek_user(child, addr, data);

		if (request == PTRACE_POKEUSR && addr == PT_IEEE_IP)

			return poke_user(child, addr, data);

#ifdef CONFIG_COMPAT

		if (request == PTRACE_PEEKUSR &&

		    addr == PT32_IEEE_IP && test_thread_flag(TIF_31BIT))

			return peek_user_emu31(child, addr, data);

		if (request == PTRACE_POKEUSR &&

		    addr == PT32_IEEE_IP && test_thread_flag(TIF_31BIT))

			return poke_user_emu31(child, addr, data);

#endif

	}



	ret = ptrace_check_attach(child, request == PTRACE_KILL);

	if (ret < 0)

		return ret;