Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 61390593 authored by Eric Long's avatar Eric Long Committed by Greg Kroah-Hartman
Browse files

coresight: etm4x: Check every parameter used by dma_xx_coherent. 



The dma_alloc_coherent return an "void *" not an "void __iomen *".
It uses the wrong parameters when calls dma_free_coherent function.

The sparse tool output logs as the following:
coresight-tmc.c:199:23:    expected void *<noident>
coresight-tmc.c:199:23:    got void [noderef] <asn:2>*vaddr
coresight-tmc.c:336:30: warning: incorrect type in assignment
(different address spaces)
coresight-tmc.c:336:30:    expected char *buf
coresight-tmc.c:336:30:    got void [noderef] <asn:2>*
coresight-tmc.c:769:50: warning: incorrect type in argument 4
(different base types)
coresight-tmc.c:769:50:    expected unsigned long long
[unsigned] [usertype] dma_handle
coresight-tmc.c:769:50:    got restricted gfp_t

Signed-off-by: default avatarEric Long <eric.long@linaro.org>
Signed-off-by: default avatarMathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent bf16e5b8

drivers/hwtracing/coresight/coresight-tmc.c

+2 −2
Original line number Diff line number Diff line
@@ -124,7 +124,7 @@ struct tmc_drvdata { 
	bool			reading;

	char			*buf;

	dma_addr_t		paddr;

	void __iomem		*vaddr;

	void			*vaddr;

	u32			size;

	bool			enable;

	enum tmc_config_type	config_type;
@@ -766,7 +766,7 @@ static int tmc_probe(struct amba_device *adev, const struct amba_id *id) 
err_devm_kzalloc:

	if (drvdata->config_type == TMC_CONFIG_TYPE_ETR)

		dma_free_coherent(dev, drvdata->size,

				&drvdata->paddr, GFP_KERNEL);

				drvdata->vaddr, drvdata->paddr);

	return ret;

}