Commit 610d886c authored Jan 19, 2017 by Jens Axboe

elevator: fix unnecessary put of elevator in failure case



We already checked that e is NULL, so no point in calling
elevator_put() to free it.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: dc877dbd088f ("blk-mq-sched: add framework for MQ capable IO schedulers")
Signed-off-by: Jens Axboe <axboe@fb.com>

parent 38dbb7dd

block/elevator.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -230,10 +230,6 @@ int elevator_init(struct request_queue q, char name)
		printk(KERN_ERR
		"Default I/O scheduler not found. " \
		"Using noop/none.\n");
		if (q->mq_ops) {
		elevator_put(e);
		return 0;
		}
		e = elevator_get("noop", false);
		}
		}