Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5fdb4505 authored by Julia Lawall's avatar Julia Lawall Committed by Chris Ball
Browse files

mmc: vub300: add missing usb_free_urb

Add missing usb_free_urb on failure path after usb_alloc_urb.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/

)

// <smpl>
@km exists@
local idexpression e;
expression e1,e2,e3;
type T,T1;
identifier f;
@@

* e = usb_alloc_urb(...)
... when any
    when != e = e1
    when != e1 = (T)e
    when != e1(...,(T)e,...)
    when != &e->f
if(...) { ... when != e2(...,(T1)e,...)
                 when != e3 = e
                 when forall
(
             return <+...e...+>;
|
*             return ...;
) }
// </smpl>

Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarChris Ball <cjb@laptop.org>
parent 4ee7ed0d
Loading
Loading
Loading
Loading
+2 −2
Original line number Diff line number Diff line
@@ -2358,9 +2358,9 @@ static int vub300_probe(struct usb_interface *interface,
	 * which is contained at the end of struct mmc
	 */
error4:
	usb_free_urb(command_out_urb);
error1:
	usb_free_urb(command_res_urb);
error1:
	usb_free_urb(command_out_urb);
error0:
	return retval;
}